----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review151248 -----------------------------------------------------------
When you say "local testing done", what did that entail? Also, did you explicitly build all the contrib/views modules with the change? - Yusaku Sako On Oct. 3, 2016, 10:46 p.m., Zhe (Joe) Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 10:46 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > ------- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > ----- > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-web/app/styles/common.less bc11d4d > ambari-web/package.json 6702471 > ambari-web/pom.xml 759b63e > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > ------- > > Local test passed. > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
