----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52602/#review151687 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java (line 59) <https://reviews.apache.org/r/52602/#comment220135> Can you add some unit test for this change to ensure that none introduces a regression by mistake? - Sebastian Toader On Oct. 6, 2016, 4:05 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52602/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 4:05 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, > and Sebastian Toader. > > > Bugs: AMBARI-18546 > https://issues.apache.org/jira/browse/AMBARI-18546 > > > Repository: ambari > > > Description > ------- > > STR: > * Install Ambari 2.4.0.1 with HDP 2.5 and Oozie (using existing MySQL DB). > * Notice that oozie-site has config, > {code} > oozie.service.JPAService.jdbc.url=jdbc:mysql://$SERVER/$oozie.db.schema.name > {code} > E.g., > jdbc:mysql://c6401.ambari.apache.org/oozie > * Export the BP, > api/v1/clusters/c1?format=blueprint > > It doesn't generate the "oozie.service.JPAService.jdbc.url" property, so a > user trying to use that blueprint will run into errors. > Further, setting the value of that property to > "jdbc:mysql://%HOSTGROUP::host_group_1%/oozie" does not actually replace it > with the hostname, and it should also dynamically replace the Oozie DB name. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 4776dc6 > > Diff: https://reviews.apache.org/r/52602/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
