----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52630/#review151788 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Toader On Oct. 7, 2016, 3:29 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52630/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 3:29 p.m.) > > > Review request for Ambari, Attila Doroszlai, Jayush Luniya, Sandor Magyari, > and Sebastian Toader. > > > Bugs: AMBARI-18554 > https://issues.apache.org/jira/browse/AMBARI-18554 > > > Repository: ambari > > > Description > ------- > > 1. use self.install_packages() > 2. declare package list in metainfo.xml instead of the install script > > > Diffs > ----- > > > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/microsoft_r.py > 382bd0f > > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/metainfo.xml > 31d5225 > > Diff: https://reviews.apache.org/r/52630/diff/ > > > Testing > ------- > > Manually tested these scenarios: > - Installing the mpack and Microsoft R > - Upgrading the cluster from HDP 2.4 -> 2.5 with Microsoft R installed. > > > Thanks, > > Balázs Bence Sári > >
