-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52749/
-----------------------------------------------------------

(Updated Oct. 12, 2016, 4:59 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
Sandor Magyari.


Bugs: AMBARI-18564
    https://issues.apache.org/jira/browse/AMBARI-18564


Repository: ambari


Description
-------

Ambari should be able to create arbitrary Kerberos identities for itself as 
declared in the Kerberos Descriptor.

Currently, Ambari is hard-coded to create identities for itself and SPNEGO, but 
that may not be good enough for all scenarios. Therefore, there needs to be an 
`AMBARI` service block in the Kerberos descriptor to allow for arbitrary 
identities to be defined for the Ambari server - similar to how any other 
service  is defined in the Kerberos descriptor.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 1153d01 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 e15965b 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 c283a65 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
 80acd0d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 0644f57 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 b2eb738 

Diff: https://reviews.apache.org/r/52749/diff/


Testing (updated)
-------

Manually tested using the UI and BP ont he trunk and brach-2.5

# Jenkins test results: 

```
+1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12832740/AMBARI-18564_trunk_01.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/8847//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/8847//console
```


Thanks,

Robert Levas

Reply via email to