-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52183/#review152301
-----------------------------------------------------------



I can't really comment on the front-end work since that's not an area I'm 
familiar with. However, I do believe there are Jiras scoping a new "wizard" 
workflow for alerts in Ambari 3.0 which this may impact.

- Jonathan Hurley


On Sept. 22, 2016, 10:24 p.m., yao lei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52183/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 10:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Zhe (Joe) Wang, and Oleg Tikhonov.
> 
> 
> Bugs: AMBARI-18423
>     https://issues.apache.org/jira/browse/AMBARI-18423
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari now only support creating/editing alert notifications of type 
> EMAIL/SNMP in web client.
> This patch aims to support another notification type  ALERT_SCRIPT
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  10a7918 
>   ambari-web/app/messages.js 2c819e5 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs a248e57 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  a0a4ce4 
> 
> Diff: https://reviews.apache.org/r/52183/diff/
> 
> 
> Testing
> -------
> 
> ambari-web/mvn test
> 
> 
> 30365 tests complete (43 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Reply via email to