-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52885/#review152724
-----------------------------------------------------------


Ship it!




Ship It!

- Di Li


On Oct. 14, 2016, 3:06 p.m., Tim Thorpe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52885/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2016, 3:06 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, and 
> Jayush Luniya.
> 
> 
> Bugs: AMBARI-18594
>     https://issues.apache.org/jira/browse/AMBARI-18594
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-18051 adds logic which breaks upgrades. The following adds:
> 
> Map<String, ServiceInfo> services = 
> getManagementController().getAmbariMetaInfo().getServices(stackName, 
> upgradePack.getTarget());
> 
> Which translates into getServices("HDP", "2.4.*.*") and results in a 
> ParentObjectNotFoundException
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
>  7e54f83 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java
>  6a0fa12 
> 
> Diff: https://reviews.apache.org/r/52885/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -Dtest=PreUpgradeCheckResourceProviderTest -DskipPythonTests
> 
> Although it was tested with code modifications to first catch the 
> ParentObjectNotFoundException without other code changes then I corrected the 
> code to use the source stack version instead of the upgrade pack target.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Reply via email to