-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52893/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and 
Sid Wagle.


Bugs: AMBARI-18603
    https://issues.apache.org/jira/browse/AMBARI-18603


Repository: ambari


Description
-------

A continuation of AMBARI-18456...

The {{ServiceComponent}} business object should have the following work 
performed:
- Remove locking around areas where its no longer required
- Replace collections with thread-safe concurrent versions
- Remove some reliance on state-full business objects (caches)


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java
 7798f26 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 fe89752 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
 8387ab8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
 282396d 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
e4adc97 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 a575456 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
 64305ff 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 6205f59 
  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
 e6a3ee6 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java
 351d473 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
 d61a3e7 
  ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 
4066d8f 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
1d1f77e 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
 3a597fd 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 30eb149 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
 8d16e3f 
  ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 
0f5c432 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
 39a3948 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
 811d98b 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 fed9b98 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java
 1012534 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
 94bd6d4 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java
 9106ec3 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java
 4c87613 
  
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
 080886e 

Diff: https://reviews.apache.org/r/52893/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley

Reply via email to