-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52930/#review152883
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 (line 267)
<https://reviews.apache.org/r/52930/#comment222066>

    Missing Javadoc


- Robert Levas


On Oct. 17, 2016, 10:28 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52930/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 10:28 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14384
>     https://issues.apache.org/jira/browse/AMBARI-14384
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Kerberos enabled cluster
> * SPNEGO enabled on hadoop APIs
> 
> /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
> 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
> http://metrics-collector:6188/ws/v1/timeline/metrics
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
> server. HTTP Error 401: Authentication required
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...
> 
> The same problem appears to be happening on the sinks:
> * 
> ambari/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
> ** No SPNEGO support
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 0e66a6d 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  efa5cba 
> 
> Diff: https://reviews.apache.org/r/52930/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to