-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52971/
-----------------------------------------------------------
Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-18621
https://issues.apache.org/jira/browse/AMBARI-18621
Repository: ambari
Description
-------
*STR:*
# Install a cluster with more than 25 nodes
# Add "Hive Metastore" hosts on nodes that are above first 25 nodes
lexicographically
*Expected Result:* On Service summary page while hovering on "Hive Metastore"
label links, all such links should display public host name in the tooltip
*Actual Result:* "Hive Metastore" hosts that are running on hosts above first
25 lexicographically does not display public host names on being hovered.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
4a07804
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
85b2b46
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
bc3f632
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
586134c
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
3b5ed28
ambari-server/src/main/resources/properties.json eb27878
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
f0bddf8
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
ef1b821
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
260ff92
ambari-web/app/controllers/global/update_controller.js 68e6ba3
ambari-web/app/mappers/component_config_mapper.js 860730e
ambari-web/app/mappers/hosts_mapper.js 6850242
ambari-web/app/mappers/service_metrics_mapper.js bf4fc91
ambari-web/app/models/host_component.js dca7ff0
ambari-web/app/templates/main/service/info/summary/master_components.hbs
460b048
Diff: https://reviews.apache.org/r/52971/diff/
Testing
-------
#Testing Done:
1. Verified on a cluster (> 25 nodes) that the patch resolves the issue
2. Verified that all unit tests for ambari-web passes with the patch
29243 tests complete (31 seconds)
154 tests pending
3. Modified and Verified ambari-server unit tests are not affected with the
patch
Results :
Failed tests:
UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1107
Unexpected method call
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface
org.apache.ambari.server.state.Cluster, EasyMock for interface
org.apache.ambari.server.state.Service):
AmbariManagementController.getClusters(): expected: at least 0, actual: 1
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for
interface org.apache.ambari.server.state.Cluster, EasyMock for interface
org.apache.ambari.server.state.Service): expected: 1, actual: 0
DataStoreImplTest.testFind:526 expected:<class
DS_DataStoreImplTest$TestEntity_1> but was:<class
DS_DataStoreImplTest$TestSubEntity_1>
DataStoreImplTest.testRemove:475 expected:<class
DS_DataStoreImplTest$TestEntity_1> but was:<class
DS_DataStoreImplTest$TestSubEntity_1>
DataStoreImplTest.testStore_update:357 expected:<class
DS_DataStoreImplTest$TestEntity_1> but was:<class
DS_DataStoreImplTest$TestSubEntity_1>
DataStoreImplTest.testStore_update_longStringValue:426
Expectation failure on verify:
DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
KerberosCheckerTest.testCheckFailed » Unexpected exception,
expected<org.apac...
KerberosCheckerTest.testCheckPassed:62 » ClassCast class
sun.security.provider...
AmbariAuthenticationFilterTest.testOnSuccessfulAuthentication:98 » Linkage
loa...
AmbariLdapAuthenticationProviderForDNWithSpaceTest.org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderForDNWithSpaceTest
» FileNotFound
AmbariLdapAuthenticationProviderForDuplicateUserTest.org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderForDuplicateUserTest
» FileNotFound
AmbariLdapAuthenticationProviderTest.org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderTest
» FileNotFound
AmbariLdapBindAuthenticatorTest.org.apache.ambari.server.security.authorization.AmbariLdapBindAuthenticatorTest
» FileNotFound
Tests run: 4644, Failures: 5, Errors: 7, Skipped: 34
Note that the tests failed are related to LDAP, Kerberos and upgradecatalog222.
These are unrelated to the changes made.
Thanks,
Jaimin Jetly
