----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52958/#review153091 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On Oct. 18, 2016, 12:48 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52958/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 12:48 p.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-18616 > https://issues.apache.org/jira/browse/AMBARI-18616 > > > Repository: ambari > > > Description > ------- > > Log Search User Config UI screen does not offer the chance to modify the > filter settings for those logs which don't have any log entries loaded so > far. For these logs the initial settings will be in effect until the first > modification of the filters when all of these settings will be erased, and > thus every log will be loaded for them without filtering. > > The User Config UI should always show all the logs, first those which already > have some log entries in the solr, then the rest. > > Also some minor refactoring for cleaner code. > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/HadoopServiceConfigHelper.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java > 58337f7 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java > 45d66cf > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java > d276769 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java > b09610c > > ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/filter/CreateLogfeederFilterView.js > 9bdf0fa > > Diff: https://reviews.apache.org/r/52958/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Miklos Gergely > >
