> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  lines 950-951
> > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line950>
> >
> >     Whitespace: missing between `){`, and extra blank line at start of 
> > method.

don't see any space between ){ - however please check latest diff.
taken out blank line at start


> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  lines 953-954
> > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line953>
> >
> >     Variable names `monitor_delay` and `monitor_dealy_long` should be 
> > camelCase, ie. `monitorDelay`.
> >     
> >     Also, `monitor_dealy_long` has typo, should be `monitorDelayLong`.

implemented


> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  line 958
> > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line958>
> >
> >     Whitespace

don't see any whitespace , however please check latest diff


> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  line 962
> > <https://reviews.apache.org/r/52839/diff/2/?file=1540039#file1540039line962>
> >
> >     Whitespace

don't see any whitespace , however please check latest diff


- Amarnath reddy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52839/#review153034
-----------------------------------------------------------


On Oct. 17, 2016, 11:07 p.m., Amarnath reddy pappu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52839/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 11:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18592
>     https://issues.apache.org/jira/browse/AMBARI-18592
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ability to enable the DEBUG logs in Ambari-server without server restart
> 
> 1. PropertyConfigurator would check log4j.properties update every 5mins. if 
> there is any change in the file/timestamp it will reload the log4j 
> configurations.
> 2. have defined to LOG4JMONITOR_DELAY for 5mins - 300000 milliseconds
> 3. Have modified only for ambari-server
> 4.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c05840e 
> 
> Diff: https://reviews.apache.org/r/52839/diff/
> 
> 
> Testing
> -------
> 
> 1. Change the log4j.properties from INFO to DEBUG
> [Expected Result] server should start logging the DEBUG logs with in 5mins of 
> time.
> [Resutl] PASS
> 
> 2. Change the log4j.properties from DEBUG to INFO
> [Expected Result] server should reduce the logging to INFO mode with in 5mins 
> of time.
> [Resutl] PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Reply via email to