----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52999/#review153199 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java (line 304) <https://reviews.apache.org/r/52999/#comment222478> Can we move this to a seaparate method instead of adding all code to run()? ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java (lines 304 - 325) <https://reviews.apache.org/r/52999/#comment222479> Minor nit: Error available sounds like is stderr available for writing, ifErrorsFound sounds more nuanced. ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java (line 312) <https://reviews.apache.org/r/52999/#comment222480> formatting ambari-server/src/main/python/ambari_server_main.py (line 105) <https://reviews.apache.org/r/52999/#comment222481> This should be configurable if it isn't. - Sid Wagle On Oct. 18, 2016, 9:50 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52999/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 9:50 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-18631 > https://issues.apache.org/jira/browse/AMBARI-18631 > > > Repository: ambari > > > Description > ------- > > Currently the database consistency check runs as a separate process prior > Ambari process. The database consistency checker load various modules needed > for performing the validations. (e.g. load stack definitions to be able to > compare service configs from stack with configs from db). > Once database consistency checker completed Ambari server is started. Ambari > server beside others loads the same modules as database consistency checker. > This double initialisation adds time to the ambari server startup time which > could be reduced if the database consistency check is moved into the ambari > server process. > Moreover the database consistency check may check at the beginning if the > database is empty and perform the checks only if there is data in the > database. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 2d91eca > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java > 535d74f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > eee7fee > ambari-server/src/main/python/ambari_server_main.py 57ec58d > > Diff: https://reviews.apache.org/r/52999/diff/ > > > Testing > ------- > > UT will be added and checked after patch draft review > > > Thanks, > > Vitalyi Brodetskyi > >
