> On Oct. 12, 2016, 8:35 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js, > > line 120 > > <https://reviews.apache.org/r/52688/diff/1/?file=1529629#file1529629line120> > > > > Why is this conditional operator required?
Not really required, could be avoided. > On Oct. 12, 2016, 8:35 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js, > > line 252 > > <https://reviews.apache.org/r/52688/diff/1/?file=1529630#file1529630line252> > > > > Is this conditional operator required? No, could be made simple as logical comparison. - Akhil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52688/#review152284 ----------------------------------------------------------- On Oct. 19, 2016, 11:42 a.m., Akhil PB wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52688/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 11:42 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-18561 > https://issues.apache.org/jira/browse/AMBARI-18561 > > > Repository: ambari > > > Description > ------- > > Calculating absolute capacity for node labels > Render sunburst chart based on node label capacity when selected > Read-only mode for non-operator users in preemption and queue mappings > Bug fixes > > > Diffs > ----- > > contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > 032b2ec > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > 1d07351 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js > d5b19ae > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > af15fa5 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 631edbb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 9d84704 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > e7fba41 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > aa139b1 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > e2d67bd > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > d838958 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 1ab1740 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > 9973708 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs > 6d398f6 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs > 8fe627e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs > f143911 > > Diff: https://reviews.apache.org/r/52688/diff/ > > > Testing > ------- > > Manual Unit Testing > > > Thanks, > > Akhil PB > >
