> On Oct. 18, 2016, 10:52 p.m., Jonathan Hurley wrote: > > Out of curiousity, instead of providing a message about removing the two > > properties, could we just have a new stage right before finalization that > > does it automatically? I know it won't restart anything, but at least the > > configs will be correct.
Thanks for the review! From Kafka team: "I think safe approach is to let the user know and let them make a decision of deleting the properties when they seem fit. Till then it will run with older log format version. second approach delete the property and go through another rolling restart of the cluster. Yes lets put a message for "log.message.format.version" once all their clients are upgraded. We shouldn't be deleting this property." - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52996/#review153239 ----------------------------------------------------------- On Oct. 18, 2016, 8:57 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52996/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 8:57 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-18630 > https://issues.apache.org/jira/browse/AMBARI-18630 > > > Repository: ambari > > > Description > ------- > > In the 2.5 upgrade pack, the following properties need to be set > {code} > inter.broker.protocol.version=0.9.0.0 > log.message.format.version=0.9.0.0 > {code} > > after upgrade is done we should delete the inter.broker.protocol.version. > Users should remove log.message.format.version once they update their clients. > > (Still waiting on final confirmation for behavior from Kafka team) > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > e8a2e2f > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml > e89d62b > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > e127dff > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml > fa1a555 > > Diff: https://reviews.apache.org/r/52996/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
