----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53086/#review153544 -----------------------------------------------------------
Ship it! Ship It! - Di Li On Oct. 21, 2016, 12:45 p.m., Tim Thorpe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53086/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 12:45 p.m.) > > > Review request for Ambari, Di Li, Jayush Luniya, and Juanjo Marron. > > > Bugs: AMBARI-18657 > https://issues.apache.org/jira/browse/AMBARI-18657 > > > Repository: ambari > > > Description > ------- > > The slider.py script in common-services should respect all possible ways of > installing slider. In a stack without storm there is no need to install the > storm slider client RPM. As a result the storm slider client directory will > be a broken link and attempting to create the storm slider client config > directory will result in an error. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider.py > 406d076 > > Diff: https://reviews.apache.org/r/53086/diff/ > > > Testing > ------- > > mvn clean test > > and installing with and without the storm slider client RPM. > > > Thanks, > > Tim Thorpe > >
