----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53091/#review153571 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Oct. 21, 2016, 3:58 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53091/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 3:58 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-18617 > https://issues.apache.org/jira/browse/AMBARI-18617 > > > Repository: ambari > > > Description > ------- > > - Navigate through Ambari Install Wizard to reach Customize Services page > - Choose Hive > - Add a custom property to Custom-hive-site > - Noticed that its getting added to Custom hivemetastore-site, > Custom hiveserver2-interactive-site, Custom hiveserver2-site, > Custom hivemetastore-site, Custom tez-interactive-site. > Please see the screen recording attached. > > > Diffs > ----- > > ambari-web/app/views/common/configs/service_configs_by_category_view.js > ed6e17a > > ambari-web/test/views/common/configs/custom_category_views/notification_configs_view_test.js > 8f03434 > > ambari-web/test/views/common/configs/service_configs_by_category_view_test.js > 9b49653 > > Diff: https://reviews.apache.org/r/53091/diff/ > > > Testing > ------- > > Verified patch manually on a cluster > Hadoop QA result posted on Jira: > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12834562/AMBARI-18617.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > +1 tests included. The patch appears to include 2 new or modified test files. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-web. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/8954//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/8954//console > This message is automatically generated. > > > Thanks, > > Jaimin Jetly > >
