> On Oct. 24, 2016, 9:34 p.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs, > > line 55 > > <https://reviews.apache.org/r/53144/diff/1/?file=1544355#file1544355line55> > > > > can this be externalized to a i18n file instead of hardcoding it at the > > UI level ?
Currently all the strings are hardcoded. Will need to open a separate jira to externalize strings. - Sangeeta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53144/#review153740 ----------------------------------------------------------- On Oct. 24, 2016, 5:20 p.m., Sangeeta Ravindran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53144/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 5:20 p.m.) > > > Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18668 > https://issues.apache.org/jira/browse/AMBARI-18668 > > > Repository: ambari > > > Description > ------- > > When you click on a workflow in the dashboard and hover over Edit Workflow > button, it shows the tooltip "Back" rather than Edit Workflow as expected. > > > Diffs > ----- > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs > 872cdbb > > Diff: https://reviews.apache.org/r/53144/diff/ > > > Testing > ------- > > Manual testing. > > Test failures are unrelated to the changes in this patch. > > > Thanks, > > Sangeeta Ravindran > >
