-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53158/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley, Mahadev Konar, Nate Cole, Robert 
Levas, Robert Nettleton, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18687
    https://issues.apache.org/jira/browse/AMBARI-18687


Repository: ambari


Description
-------

AMBARI-18687: Ambari-agent - CLI utility to support storing passwords using 
hadoop credential store

** Issue: ** Ambari-agent python script requires a way to create credentials in 
a hadoop credential store. 

** Fix: ** A Java CLI with CRUD commands that use the Hadoop Credential Store 
API and the CredentialShell utility is required. The JAR will be packaged with 
ambari agent and callable from the Python code.


Diffs
-----

  ambari-agent/pom.xml a8ed7f1dd54bc2286677bb523b2a54e25d7af2b6 
  
ambari-agent/src/main/java/org/apache/ambari/agent/security/util/AmbariCredentialShell.java
 PRE-CREATION 
  
ambari-agent/src/main/java/org/apache/ambari/agent/security/util/ambarics.java 
PRE-CREATION 
  
ambari-agent/src/test/java/org/apache/ambari/agent/security/util/AmbariCredentialShellTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/53158/diff/


Testing
-------

** 1. mvn clean install **

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Web ........................................ SUCCESS [1:14.498s]
[INFO] Ambari Views ...................................... SUCCESS [1.149s]
[INFO] Ambari Admin View ................................. SUCCESS [7.601s]
[INFO] utility ........................................... SUCCESS [0.337s]
[INFO] ambari-metrics .................................... SUCCESS [0.392s]
[INFO] Ambari Metrics Common ............................. SUCCESS [12.513s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [3.254s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [2.771s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [2.694s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [4.914s]
[INFO] Ambari Metrics Storm Sink (Legacy) ................ SUCCESS [2.654s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [8.960s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [2.207s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [0.764s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [1:17.555s]
[INFO] Ambari Server ..................................... SUCCESS [2:43.336s]
[INFO] Ambari Functional Tests ........................... SUCCESS [1.127s]
[INFO] Ambari Agent ...................................... SUCCESS [26.487s]
[INFO] Ambari Client ..................................... SUCCESS [0.023s]
[INFO] Ambari Python Client .............................. SUCCESS [0.912s]
[INFO] Ambari Groovy Client .............................. SUCCESS [1.986s]
[INFO] Ambari Shell ...................................... SUCCESS [0.018s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.622s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [0.740s]
[INFO] ambari-logsearch .................................. SUCCESS [0.123s]
[INFO] Ambari Logsearch Appender ......................... SUCCESS [0.174s]
[INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.098s]
[INFO] Ambari Logsearch Portal ........................... SUCCESS [6.155s]
[INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [4.004s]
[INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.073s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:50.043s
[INFO] Finished at: Mon Oct 24 16:16:04 PDT 2016
[INFO] Final Memory: 319M/1158M
[INFO] ------------------------------------------------------------------------

** 2. Added 17 new Unit Tests **
** mvn test -DskipPythonTests **

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true
Running org.apache.ambari.agent.security.util.AmbariCredentialShellTest
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.585 sec - in 
org.apache.ambari.agent.security.util.AmbariCredentialShellTest

Results :

Tests run: 17, Failures: 0, Errors: 0, Skipped: 0
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 153 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.574s
[INFO] Finished at: Mon Oct 24 16:57:43 PDT 2016
[INFO] Final Memory: 22M/316M
[INFO] ------------------------------------------------------------------------


Thanks,

Nahappan Somasundaram

Reply via email to