----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53101/#review153798 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Oct. 25, 2016, 10:50 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53101/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 10:50 a.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and > Oliver Szabo. > > > Bugs: AMBARI-18664 > https://issues.apache.org/jira/browse/AMBARI-18664 > > > Repository: ambari > > > Description > ------- > > While syncing with LDAP, username collisions should be handled based on an > LDAP sync configuration value. > > The configuration options should be to indicate the following behaviors > - convert > -- convert the existing (non-LDAP user) user to an LDAP user > -- This is the existing behavior > - skip > -- skip or ignore the collision, leaving the existing user unchanged > -- a new user record should not be created > > Note: Future behavior may be to cause the sync operation to fail, but that > shouldn't be handed yet. > > This configuration value should be set when setting up LDAP sync properties > via `ambari-server setup-ldap` and be enforced when processing the sync > operation in methods like > `org.apache.ambari.server.controller.AmbariManagementControllerImpl#synchronizeLdapUsersAndGroups` > or `org.apache.ambari.server.security.authorization.Users#processLdapSync`. > > > Diffs > ----- > > ambari-server/docs/configuration/index.md 3c3f3d0 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 12e36c3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java > 9939e08 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/LdapSyncEventEntity.java > 5b361c3 > > ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java > 91ef97a > > ambari-server/src/main/java/org/apache/ambari/server/security/ldap/LdapBatchDto.java > bb9c5ee > ambari-server/src/main/python/ambari-server.py f7ce80c > ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 > > ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java > 34eadad > ambari-server/src/test/python/TestAmbariServer.py 5746503 > > Diff: https://reviews.apache.org/r/53101/diff/ > > > Testing > ------- > > > Thanks, > > Robert Levas > >
