----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53192/#review154010 -----------------------------------------------------------
Ship it! We really need to rename NONROLLING - :) ... but that's not for this review. The only nit is the name of the XML for HOST_ORDERED; can we call it host-ordered-upgrade-2.5.xml ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeType.java (line 40) <https://reviews.apache.org/r/53192/#comment223531> Can we please rename this to EXPRESS :) ambari-server/src/main/resources/upgrade-pack.xsd (line 30) <https://reviews.apache.org/r/53192/#comment223532> EXPRESS :) - Jonathan Hurley On Oct. 26, 2016, 1:05 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53192/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 1:05 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-18679 > https://issues.apache.org/jira/browse/AMBARI-18679 > > > Repository: ambari > > > Description > ------- > > Add skeleton and enum etc for Host-Ordered upgrades. > > Host Ordered is a hybrid of Express and Rolling, whereby all components on a > host are stopped, the upgrade pauses, then the components start. Continue > host-by-host until all services are upgraded. > > This doesn't contain any new orchestration logic, that will happen as a > separate jira. Upgrade Pack in this diff likely will be changed > significantly; it's just a starting point. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > be1f469 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/UpgradeType.java > ff31008 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml > PRE-CREATION > ambari-server/src/main/resources/upgrade-pack.xsd b02d941 > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java > 6c81c61 > > ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_host_ordered.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/53192/diff/ > > > Testing > ------- > > Manual. Automated: > > Tests run: 4665, Failures: 0, Errors: 0, Skipped: 42 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:10:24.649s > [INFO] Finished at: Wed Oct 26 12:57:25 EDT 2016 > [INFO] Final Memory: 36M/660M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
