----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53211/#review154056 -----------------------------------------------------------
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step7_controller.js (lines 25 - 32) <https://reviews.apache.org/r/53211/#comment223576> Lets splice out startRanger command if Ranger service is not present in the cluster simialr to what we do to reconfigure ranger task in step9_controller. ambari-web/app/controllers/main/admin/highAvailability/nameNode/step7_controller.js (line 29) <https://reviews.apache.org/r/53211/#comment223577> This will always evaluate to true as hostname is an array and even empty array evaluated to true in conditioanl check. Please chage this to hostname.length - Jaimin Jetly On Oct. 26, 2016, 11:30 p.m., Vivek Ratnavel Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53211/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 11:30 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-18706 > https://issues.apache.org/jira/browse/AMBARI-18706 > > > Repository: ambari > > > Description > ------- > > When Ranger is installed and the user tries to enable NamenodeHA in HDFS, the > following exception is encountered since a property is not configured > properly in all the dependent services. > > > Diffs > ----- > > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step3_controller.js > 1dcf2b7 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step5_controller.js > 68366f6 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step7_controller.js > 0bfd1c9 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step9_controller.js > 05c6a58 > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/wizard_controller.js > 72f9ec2 > ambari-web/app/data/HDP2/ha_properties.js 388f85d > ambari-web/app/messages.js a3c5e58 > ambari-web/app/routes/high_availability_routes.js 9530232 > ambari-web/app/utils/ajax/ajax.js b761a14 > ambari-web/app/utils/configs/nn_ha_config_initializer.js 3a48e8d > > ambari-web/test/controllers/main/admin/highAvailability/nameNode/step3_controller_test.js > dfe2076 > > Diff: https://reviews.apache.org/r/53211/diff/ > > > Testing > ------- > > Verified Manually. > Unit tests modified. > Ambari-web unit tests pass. > 30372 tests complete (28 seconds) > 151 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
