-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53251/
-----------------------------------------------------------
(Updated Oct. 28, 2016, 12:58 p.m.)
Review request for Ambari, Nate Cole and Robert Levas.
Changes
-------
Wrong diff attached previously.
Bugs: AMBARI-18726
https://issues.apache.org/jira/browse/AMBARI-18726
Repository: ambari
Description
-------
Add a way to compute whether an execute-stage should be included, other than
the simple service/component check.
For example some stage should only be executed if the cluster has Kerberos
enabled. This can be determined using the {{cluster-env/security_enabled}}
flag; or (better yet) the {{Cluster}}'s {{securityType}} property, which would
be set to "KERBEROS".
Currently the only filter is based on service and component, which does not
work in the case of Kerberos since Kerberos can be enabled without needing to
install the KERBEROS service or the KERBEROS_CLIENT component. This will happen
if the Kerberos identities are managed manually rather than configuring Ambari
to do it by integrating with a supported KDC.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/SecurityType.java
dc52c4e
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
2f616e7
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
3a2dc89
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
80bb26c
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
be1f469
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/SecurityCondition.java
PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml
e3bb29d
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
87afdbc
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
e082f72
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
ed81582
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
3cc0a65
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
e8e00f0
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml
790e5dc
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
01e0601
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
2925b64
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
266c71b
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
9e141ae
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml
8b00893
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml
6cc1106
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml
b0b78a0
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml
adc1a29
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
d1e1059
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
9021761
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
9c7af5a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml
390f18e
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml
6af7767
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml
1dea612
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
5e3561a
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
ea829e2
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml
b02cbad
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml
7b4472e
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
ca107af
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml
7b4472e
ambari-server/src/main/resources/upgrade-pack.xsd ad2a47d
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
d644a09
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java
267932c
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_direction.xml
92fd0b2
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml
789df2e
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml
5e02b15
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_checks.xml
c6d8bbe
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_nonrolling.xml
36f8062
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_partial.xml
5d8ef01
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml
91770fb
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test.xml
021c73a
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_15388.xml
d1dc62d
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_checks.xml
273f619
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_conditions.xml
PRE-CREATION
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/upgrade_test_15388.xml
905def5
Diff: https://reviews.apache.org/r/53251/diff/
Testing
-------
Tests run: 4718, Failures: 0, Errors: 0, Skipped: 42
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:57 min
[INFO] Finished at: 2016-10-28T08:49:12-04:00
[INFO] Final Memory: 55M/762M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
