----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review154268 -----------------------------------------------------------
Just a comment/question below about the filtering used here. I could recommend checking the Ambari stack definitions, to make sure this filter won't accidentally remove more than necessary. Thanks. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java (line 2993) <https://reviews.apache.org/r/53213/#comment223763> Are we sure that all properties that include the string "principal" should be excluded? Are all of these properties certain to have the cluster-specific name that would be an issue for portability? Given the general nature of this property name matcher, I'd be a little concerned that maybe more is being filtered out than necessary. I'm not sure that this is definitely a problem, but it might be a good idea to double-check the stack definitions, to make sure that only the problematic properties are being excluded. - Robert Nettleton On Oct. 28, 2016, 5:50 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53213/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2016, 5:50 p.m.) > > > Review request for Ambari, Di Li, Robert Levas, and Robert Nettleton. > > > Bugs: AMBARI-18692 > https://issues.apache.org/jira/browse/AMBARI-18692 > > > Repository: ambari > > > Description > ------- > > Exporting blueprint from kerberos enabled cluster, exports hardcoded values > cluster name and realm in principal_name property. > When the same blueprint is used to create another cluster with different > name, service start fail with following error: > "resource_management.core.exceptions.Fail: Execution of '/usr/bin/kinit -kt > /etc/security/keytabs/hdfs.headless.keytab [keytab_name_in_blueprint] eturned > 1. kinit: Keytab contains no suitable keys for [keytab_name_in_blueprint] > while getting initial credentials" > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > f890326 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 5bedb9d > > Diff: https://reviews.apache.org/r/53213/diff/ > > > Testing > ------- > > Tested manually. Suitable keytabs are generated automatically when not > mentioned in blueprint. Service starts succeeded with a blueprint exported > with the code change. > Modified existing unit test cases. > > > Thanks, > > Amruta Borkar > >
