----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53332/#review154351 -----------------------------------------------------------
Ship it! Ship It! - Zhe (Joe) Wang On Nov. 1, 2016, 12:04 a.m., Xi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53332/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 12:04 a.m.) > > > Review request for Ambari, Zhe (Joe) Wang and Richard Zang. > > > Repository: ambari > > > Description > ------- > > Wizard improvements on Ambari UI: > The footer of the wizard (back & next button area) should be separated, not > with the content panel > The content panel should be on a white canvas, separated from step > title/description. > > Changes from the style guides: > 1. Narrow down wizard nav items. > 2. In wizard header and footer, should reduce the padding > 3. In wizard content, there should be no border for content panel, also > should reduce step title margin > > > Diffs > ----- > > ambari-web/app/templates/common/assign_master_components.hbs a9da3e5 > ambari-web/app/templates/common/progress.hbs 90a85a9 > ambari-web/app/templates/installer.hbs 4cac80c > > ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/step1.hbs > 47f9dc2 > > ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/step2.hbs > 984df84 > > ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/wizard.hbs > 23cfcf0 > > ambari-web/app/templates/main/admin/highAvailability/hawq/addStandby/step1.hbs > 2e315e3 > > ambari-web/app/templates/main/admin/highAvailability/hawq/addStandby/step3.hbs > 02ed51b > > ambari-web/app/templates/main/admin/highAvailability/hawq/addStandby/wizard.hbs > 7c21df4 > > ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step1.hbs > 02ceb03 > > ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step2.hbs > 014c25a > > ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/wizard.hbs > 13714df > ambari-web/app/templates/main/admin/highAvailability/journalNode/step1.hbs > e9e6fec > ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs > 67a63fd > ambari-web/app/templates/main/admin/highAvailability/journalNode/step3.hbs > b87497f > ambari-web/app/templates/main/admin/highAvailability/journalNode/step5.hbs > 53634cd > ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs > c191d50 > > ambari-web/app/templates/main/admin/highAvailability/nameNode/rollbackHA/rollback_wizard.hbs > 9d325c6 > > ambari-web/app/templates/main/admin/highAvailability/nameNode/rollbackHA/step1.hbs > 16330b9 > > ambari-web/app/templates/main/admin/highAvailability/nameNode/rollbackHA/step2.hbs > 10b14d1 > > ambari-web/app/templates/main/admin/highAvailability/nameNode/rollbackHA/step3.hbs > 850b4e3 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step1.hbs > 63793e8 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step3.hbs > 0536898 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step4.hbs > b864a39 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step6.hbs > 441f94c > ambari-web/app/templates/main/admin/highAvailability/nameNode/step8.hbs > f52b0ba > ambari-web/app/templates/main/admin/highAvailability/nameNode/wizard.hbs > a9d5d5c > ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step1.hbs > ac248d0 > ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step3.hbs > c229662 > ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/wizard.hbs > b5b6897 > > ambari-web/app/templates/main/admin/highAvailability/resourceManager/step1.hbs > e3e115b > > ambari-web/app/templates/main/admin/highAvailability/resourceManager/step3.hbs > de5ed63 > > ambari-web/app/templates/main/admin/highAvailability/resourceManager/wizard.hbs > 34de9e7 > ambari-web/app/templates/main/admin/kerberos/step1.hbs 7f8979b > ambari-web/app/templates/main/admin/kerberos/step2.hbs 47632a8 > ambari-web/app/templates/main/admin/kerberos/step3.hbs 4fd35a0 > ambari-web/app/templates/main/admin/kerberos/step4.hbs 1c5d281 > ambari-web/app/templates/main/admin/kerberos/step5.hbs 1e5af83 > ambari-web/app/templates/main/admin/kerberos/wizard.hbs 63ec8bf > > ambari-web/app/templates/main/alerts/add_alert_definition/add_alert_definition.hbs > 64e0e40 > ambari-web/app/templates/main/alerts/add_alert_definition/step1.hbs 9b207cd > ambari-web/app/templates/main/alerts/add_alert_definition/step2.hbs 27db700 > ambari-web/app/templates/main/alerts/add_alert_definition/step3.hbs 713c5ab > ambari-web/app/templates/main/host/add.hbs c75e0ce > ambari-web/app/templates/main/service/add.hbs a3d5f2e > ambari-web/app/templates/main/service/reassign.hbs 49a89c3 > ambari-web/app/templates/main/service/widgets/create/step1.hbs e465bcb > ambari-web/app/templates/main/service/widgets/create/step2.hbs 021f051 > ambari-web/app/templates/main/service/widgets/create/step2_graph.hbs > 0040a9f > ambari-web/app/templates/main/service/widgets/create/step2_number.hbs > 13c4f4b > ambari-web/app/templates/main/service/widgets/create/step2_template.hbs > 6c0722a > ambari-web/app/templates/main/service/widgets/create/step3.hbs a4ee81c > ambari-web/app/templates/main/service/widgets/create/wizard.hbs 8e9a98b > ambari-web/app/templates/main/service/widgets/edit.hbs 8ac1a55 > ambari-web/app/templates/wizard/step0.hbs 38f9269 > ambari-web/app/templates/wizard/step1.hbs 977a8fa > ambari-web/app/templates/wizard/step10.hbs f2caf9c > ambari-web/app/templates/wizard/step2.hbs f9a0928 > ambari-web/app/templates/wizard/step3.hbs 72881cf > ambari-web/app/templates/wizard/step4.hbs ab7a8fa > ambari-web/app/templates/wizard/step6.hbs f4fea26 > ambari-web/app/templates/wizard/step7.hbs 0f8fa8d > ambari-web/app/templates/wizard/step8.hbs 1af0683 > ambari-web/app/templates/wizard/step9.hbs d1bcf3d > > Diff: https://reviews.apache.org/r/53332/diff/ > > > Testing > ------- > > 26147 tests complete (20 seconds) > 57 tests pending > > > Thanks, > > Xi Wang > >
