----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50561/#review154502 -----------------------------------------------------------
Ship it! Ship It! contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js (line 154) <https://reviews.apache.org/r/50561/#comment224082> You could write a css class rather including inline styles. - Pallav Kulshreshtha On July 28, 2016, 11:22 a.m., Nitiraj Rathore wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50561/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 11:22 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17943 > https://issues.apache.org/jira/browse/AMBARI-17943 > > > Repository: ambari > > > Description > ------- > > removed the linefeed and carriage return and improved UX > > > Diffs > ----- > > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 061a445 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > d84dc4d > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 061a445 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > d84dc4d > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVParserTest.java > 2c890f5 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVTest.java > be5733f > > Diff: https://reviews.apache.org/r/50561/diff/ > > > Testing > ------- > > manual testing done > > > Thanks, > > Nitiraj Rathore > >
