-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53412/
-----------------------------------------------------------
(Updated Nov. 3, 2016, 8:51 a.m.)
Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Robert
Nettleton, Sumit Mohanty, and Sid Wagle.
Changes
-------
1. Added documentation to <pre> section.
2. Exit early if setting is null in getCredentialStoreEnabled().
Bugs: AMBARI-18778
https://issues.apache.org/jira/browse/AMBARI-18778
Repository: ambari
Description
-------
AMBARI-18778: Ambari-server: Blueprint enhancements to support enabling or
disabling credential store
** Blueprint deployments **
Use the *settings/service_settings* section of the blueprint to specify whether
a service uses credential store or not. For example:
```json
{ "settings" :
{
"service_settings" : [
{ "name" : "RANGER",
"recovery_enabled" : "true",
"credential_store_enabled" : "true"
},
{ "name" : "HIVE",
"recovery_enabled" : "true",
"credential_store_enabled" : "false"
},
{ "name" : "TEZ",
"recovery_enabled" : "false"
}
]
}
}
```
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
b11d9d3a32d10ed12fe51e7e72211e4fa007920b
ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java
8061f37a78aa3d25cef0b318af77175fc4a0df9d
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
df0187e1d625e1441b548e4a845b1af79a75ef34
ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java
601cbfd1bc7aa6abdb3c8879ffe252724991cd37
ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
6ef240de33d2875c1ab2fafc61472aa5c64e0cee
Diff: https://reviews.apache.org/r/53412/diff/
Testing
-------
** 1. mvn clean install -DskipTests **
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [12.938s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.060s]
[INFO] Ambari Web ........................................ SUCCESS [1:12.696s]
[INFO] Ambari Views ...................................... SUCCESS [1.173s]
[INFO] Ambari Admin View ................................. SUCCESS [6.390s]
[INFO] utility ........................................... SUCCESS [0.322s]
[INFO] ambari-metrics .................................... SUCCESS [0.658s]
[INFO] Ambari Metrics Common ............................. SUCCESS [6.547s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [3.451s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.450s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.412s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.927s]
[INFO] Ambari Metrics Storm Sink (Legacy) ................ SUCCESS [1.862s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [10.291s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [2.198s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [0.895s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [1:15.344s]
[INFO] Ambari Server ..................................... SUCCESS [2:44.173s]
[INFO] Ambari Functional Tests ........................... SUCCESS [0.910s]
[INFO] Ambari Agent ...................................... SUCCESS [24.648s]
[INFO] Ambari Client ..................................... SUCCESS [0.039s]
[INFO] Ambari Python Client .............................. SUCCESS [0.826s]
[INFO] Ambari Groovy Client .............................. SUCCESS [1.967s]
[INFO] Ambari Shell ...................................... SUCCESS [0.033s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.709s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [0.905s]
[INFO] ambari-logsearch .................................. SUCCESS [0.217s]
[INFO] Ambari Logsearch Appender ......................... SUCCESS [0.199s]
[INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.084s]
[INFO] Ambari Logsearch Portal ........................... SUCCESS [5.976s]
[INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [3.723s]
[INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.073s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:47.801s
[INFO] Finished at: Wed Nov 02 16:48:37 PDT 2016
[INFO] Final Memory: 315M/1215M
[INFO] ------------------------------------------------------------------------
** 2. Manual tests **
Deployed a blueprint with the following settings section:
```json
{ "settings" :
{
"service_settings" : [
{ "name" : "RANGER",
"recovery_enabled" : "true",
"credential_store_enabled" : "true"
},
{ "name" : "HIVE",
"recovery_enabled" : "true",
"credential_store_enabled" : "false"
},
{ "name" : "TEZ",
"recovery_enabled" : "false"
},
:
]
}
}
```
curl -u admin:admin -H "X-Requested-By: ambari" -X POST -d
@/tmp/blueprints1.json http://localhost:8080/api/v1/blueprints/bp1
curl -u admin:admin -H "X-Requested-By: ambari" -X POST -d @/tmp/hg1.json
http://localhost:8080/api/v1/clusters/c1
Verified that the value of "false" for **credential_store_enabled** for HIVE
overrode the value of "true" from the stack definition. For services where
**credential_store_enabled** was not specified, it was picked up from the stack
definition if available.
Thanks,
Nahappan Somasundaram
