----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53433/#review154764 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java <https://reviews.apache.org/r/53433/#comment224446> Nice catch! Invalidation during an upgrade failure would have removed all hosts ... ewwww ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java (line 75) <https://reviews.apache.org/r/53433/#comment224448> Can this be made final? ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java (lines 118 - 120) <https://reviews.apache.org/r/53433/#comment224449> Could hosts be null if not supplied as part of this HostOrderItem? Might want to use CollectionUtils.isEmpty() here. ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java (lines 193 - 195) <https://reviews.apache.org/r/53433/#comment224450> Same as above - could this be null from the API request if it's a separate JSON object with just hosts? ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java (line 207) <https://reviews.apache.org/r/53433/#comment224451> Maybe a WARNING? The invoker should know what services are installed. - Jonathan Hurley On Nov. 3, 2016, 12:18 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53433/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 12:18 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-18680 > https://issues.apache.org/jira/browse/AMBARI-18680 > > > Repository: ambari > > > Description > ------- > > Adds orchestration for HOST_ORDERED. Added unit test and uses code that was > checked in recently. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > 706a476 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > f3dca62 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java > 267133b > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml > d59be50 > ambari-server/src/main/resources/upgrade-pack.xsd cfccb29 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 52e6513 > > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test_host_ordered.xml > b7ffb89 > > ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_host_ordered.xml > 6a49472 > > Diff: https://reviews.apache.org/r/53433/diff/ > > > Testing > ------- > > Manual. Automated: > > (Failed test has nothing to do with current patch - the test is flaky) > > Failed tests: > TestHeartbeatHandler.testRegistrationRecoveryConfig:432 null > > Tests run: 4723, Failures: 1, Errors: 0, Skipped: 42 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34:27.732s > [INFO] Finished at: Thu Nov 03 12:06:26 EDT 2016 > [INFO] Final Memory: 37M/651M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
