----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53506/#review155046 -----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/HostInfo.py (line 120) <https://reviews.apache.org/r/53506/#comment224890> This should return a ('chronyd', 'ntp') since both are valid. Need to chnage the caller to do a OR. - Sid Wagle On Nov. 5, 2016, 1:13 a.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53506/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2016, 1:13 a.m.) > > > Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-18761 > https://issues.apache.org/jira/browse/AMBARI-18761 > > > Repository: ambari > > > Description > ------- > > I use CentOS 7 as a host OS. When the host check runs, it shows warning. The > warning says "The following services should be up: Service ntpd." > I think "chrony" is a default NTP client and server on CentOS7. So We should > check if there are ntpd or chronyd on a host. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/HostInfo.py 3871e72 > > Diff: https://reviews.apache.org/r/53506/diff/ > > > Testing > ------- > > ``` > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12837135/AMBARI-18761.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in . > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/9144//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/9144//console > This message is automatically generated. > ``` > > Manual test: Installed Ambari2.4.1 on centos7, replaced HostInfo.py and > recheck host. > > > Thanks, > > Masahiro Tanaka > >
