----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53544/#review155160 -----------------------------------------------------------
Fix it, then Ship it! Ship It! ambari-server/docs/configuration/index.md (line 76) <https://reviews.apache.org/r/53544/#comment224997> This is an incorrect or confusing property name. The `authentication.*` properties control aspects of the authentication mechanism into Ambari. In this case we are creating a property to control behavior when creating Kerberos identities for the cluster, so the name of the propery seems confusing to me. How about something like `kerberos.kadmin.call.retries` or maybe something more generic like `kerberos.operation.retries` which might cover other operations like access to Active Directory's LDAP interface or some FreeIPA call. The `kerberos.*` properties (for example, `kerberos.keytab.cache.dir`) seem to be more related to processing tasks needed when creating Kerberos identities. ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java (lines 1392 - 1393) <https://reviews.apache.org/r/53544/#comment224998> This is an incorrect or confusing property name. The `authentication.*` properties control aspects of the authentication mechanism into Ambari. In this case we are creating a property to control behavior when creating Kerberos identities for the cluster, so the name of the propery seems confusing to me. How about something like `kerberos.kadmin.call.retries` or maybe something more generic like `kerberos.operation.retries` which might cover other operations like access to Active Directory's LDAP interface or some FreeIPA call. The `kerberos.*` properties (for example, `kerberos.keytab.cache.dir`) seem to be more related to processing tasks needed when creating Kerberos identities. - Robert Levas On Nov. 7, 2016, 11:48 a.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53544/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 11:48 a.m.) > > > Review request for Ambari and Robert Levas. > > > Bugs: AMBARI-18755 > https://issues.apache.org/jira/browse/AMBARI-18755 > > > Repository: ambari > > > Description > ------- > > Cluster deployment via blueprint failed at creating principals > > > > > 2016-10-31 20:23:01,076 - Failed to create principal, > kafka/[email protected] - Unexpected > error condition executing the kadmin command > > > This looks like intermittent issue since not all jobs hit it. > > Here is a live cluster: <http://172.22.94.246:8080/#/main/dashboard/metrics> > > > Diffs > ----- > > ambari-server/docs/configuration/index.md 52b4744 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 86c26c8 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java > 7e915fc > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java > 6fd30ee > > Diff: https://reviews.apache.org/r/53544/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
