> On Nov. 8, 2016, 5:21 p.m., Jayush Luniya wrote: > > ambari-web/test/utils/config_test.js, line 134 > > <https://reviews.apache.org/r/53564/diff/1/?file=1556454#file1556454line134> > > > > The message is a bit misleading. HDF-2.0 is equivalent to HDP-2.5. The > > logic really is for which base stack folder to use. > > > > Also is there a long term solution to make this logic stack agnostic?
>> The message is a bit misleading. HDF-2.0 is equivalent to HDP-2.5. The logic >> really is for which base stack folder to use. we don't have any hard coded config property related definitions specific to HDP-2.4 and HDP-2.5 in ambari-web. so any stack greater than HDP-2.3 (HDP-2.4 or HDP-2.5) or corresponding to HDP stack greater than HDP-2.3 (HDF-2.0) should be extending of HDP-2.3 stack definition >> Also is there a long term solution to make this logic stack agnostic? Ideal stack agnostic solution needs to be scoped and will definietely take more code changes which is not advisable to be done for immediate Ambari-2.4.2 release. We can scope it for Ambari-3.0.0 (based on trunk). I have created https://issues.apache.org/jira/browse/AMBARI-18826 for that. - Jaimin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53564/#review155307 ----------------------------------------------------------- On Nov. 8, 2016, 2:45 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53564/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 2:45 a.m.) > > > Review request for Ambari, Jayush Luniya, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18816 > https://issues.apache.org/jira/browse/AMBARI-18816 > > > Repository: ambari > > > Description > ------- > > Ranger install asks to populate AD domain and marks its required when no AD > is in play > > > Diffs > ----- > > ambari-web/app/data/custom_stack_map.js 33b642c > ambari-web/app/utils/config.js e83d42c > ambari-web/test/utils/config_test.js 35d272d > > Diff: https://reviews.apache.org/r/53564/diff/ > > > Testing > ------- > > Added new unit test. > Verified that all existing unit tests passes: > > > 29250 tests complete (29 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
