> On Nov. 9, 2016, 5:56 a.m., Sebastian Toader wrote: > > ambari-server/docs/configuration/index.md, line 102 > > <https://reviews.apache.org/r/53583/diff/1/?file=1556762#file1556762line102> > > > > Do we need to add the ```index.md``` file to the patch for review or > > not as this is autogenerated from during build from the Markdowns?
It's not autogenerated - it's checked-in source so it renders on Github. There is a way to generate it by invoking the main() method of Configuration. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53583/#review155419 ----------------------------------------------------------- On Nov. 8, 2016, 2:09 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53583/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 2:09 p.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and > Sebastian Toader. > > > Bugs: AMBARI-18813 > https://issues.apache.org/jira/browse/AMBARI-18813 > > > Repository: ambari > > > Description > ------- > > Optionally force username from LDAP authentication data to be lowercase in > Ambari based on LDAP import configuration. > > In some cases the username declared in the relevant LDAP object is in all > uppercase characters when the local Hadoop cluster expects the username to be > all lowercase. As of Ambari 2.4.0, the username specified from the LDAP data > is used to override the username known to Ambari. This overwritten data may > be in all uppercase characters, potentially breaking local username > conventions. > > To help this scenario, provide a configuration option to force the username > obtained from the LDAP object to be converted to all lowercase character. > > For example `authentication.ldap.username.forceLowercase`. > > This optional configuration value is to default to false to maintain current > functionality. > > > Diffs > ----- > > ambari-server/docs/configuration/index.md 52b4744 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 3103b6d > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java > 917471b > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java > a3086693 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticatorTest.java > 6e4b836 > > Diff: https://reviews.apache.org/r/53583/diff/ > > > Testing > ------- > > Manually tested... > > # Local test results: > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 37:51.683s > [INFO] Finished at: Tue Nov 08 10:51:17 EST 2016 > [INFO] Final Memory: 62M/834M > [INFO] > ------------------------------------------------------------------------ > > # Jenkins test result: PENDING > > > Thanks, > > Robert Levas > >
