> On Nov. 9, 2016, 9:49 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java, > > line 102 > > <https://reviews.apache.org/r/53603/diff/1/?file=1559343#file1559343line102> > > > > Don't use instanceof here - you can use the NotificationType > > Dmytro Sen wrote: > Notification type contains only Subject and Body, both of String type, so > needed data can't be passed using it
No, I mean, use the notification.getType() method :) - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53603/#review155435 ----------------------------------------------------------- On Nov. 9, 2016, 7:36 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53603/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 7:36 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-18833 > https://issues.apache.org/jira/browse/AMBARI-18833 > > > Repository: ambari > > > Description > ------- > > Currently, Ambari's SNMP alert target type is using to bind generic OIDs > specified by the administrator when creating the target. Many users would > rather that Ambari provide a MIB which can then be imported into their > management tool and just use the pre-defined OIDs. > Ambari has applied for and received OIDs from Apache which are included in > our MIB file. The MIB is located at: > https://github.com/apache/ambari/blob/trunk/contrib/alert-snmp-mib/APACHE-AMBARI-MIB.txt > The known Ambari OIDs are defined at: > https://cwiki.apache.org/confluence/display/DIRxPMGT/OID+Assignment+Scheme > 1.3.6.1.4.1.18060.16 > A new alert target type of AMBARI_SNMP should be created which knows about > the pre-existing OIDs so that dispatching SNMP traps to this type are > correctly bound automatically. > > > Diffs > ----- > > ambari-server/docs/configuration/index.md 52b4744 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 3103b6d > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > e32e653 > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/SNMPDispatcher.java > 22a78ef > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java > 958740a > > ambari-server/src/main/java/org/apache/ambari/server/state/alert/TargetType.java > 53be9e1 > > ambari-server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java > 9e424f7 > > ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcherTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53603/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
