----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53602/#review155461 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py (lines 397 - 406) <https://reviews.apache.org/r/53602/#comment225436> +1 on removing the break. - Sid Wagle On Nov. 9, 2016, 12:08 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53602/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 12:08 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-18832 > https://issues.apache.org/jira/browse/AMBARI-18832 > > > Repository: ambari > > > Description > ------- > > A single missing directory named `namenode-formatted` can result in Ambari > reformatting the NameNode and causing total data loss in a cluster. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py > b7735f4 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 4cfa2b2 > > Diff: https://reviews.apache.org/r/53602/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
