----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53617/#review155462 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py (line 410) <https://reviews.apache.org/r/53617/#comment225437> This was required to prevent calls to conf_select during STOP commands. ambari-common/src/main/python/resource_management/libraries/script/script.py (line 679) <https://reviews.apache.org/r/53617/#comment225438> It's not a "restart_type" ... Figured now was a good time to change it. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java (lines 1404 - 1406) <https://reviews.apache.org/r/53617/#comment225439> Future additions to the UpgradeType will not automatically be serialized. ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_service.py <https://reviews.apache.org/r/53617/#comment225440> Removed as this is no longer an issue on newer versions of Ambari/HDP - Jonathan Hurley On Nov. 9, 2016, 1:03 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53617/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 1:03 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: BUG-18682 > https://issues.apache.org/jira/browse/BUG-18682 > > > Repository: ambari > > > Description > ------- > > Zookeeper agent code is incorrectly calling stack_select ({{hdp-select}}) > when it should not be. {{hdp_select}} and {{conf_select}} should only be > executed during RU/EU. This Jira should cover the following areas: > > - Ensure that hdp-/conf-select are only invoked during an actual upgrade as > to not interfere with {{HOST_ORDERED}} upgrade commands. > - Add the {{HOST_ORDERED}} upgrade type to commands so that ZK knows when to > invoke hdp-/conf-select. > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/constants.py 779b204 > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > 8d54053 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 6e567d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 02c05d9 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py > 02eb192 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 5b0dcea > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 4e402e5 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/zookeeper_service.py > 5069396 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py > f19c321 > ambari-server/src/test/python/stacks/2.0.6/configs/client-upgrade.json > 945ebbc > ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu.json 2b54a82 > ambari-server/src/test/python/stacks/2.0.6/configs/nn_eu_standby.json > c2281f9 > ambari-server/src/test/python/stacks/2.0.6/configs/nn_ru_lzo.json d44b002 > ambari-server/src/test/python/stacks/2.1/configs/client-upgrade.json > b279a33 > > ambari-server/src/test/python/stacks/2.1/configs/hive-metastore-upgrade.json > 6a3a94a > ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json > 27280f7 > ambari-server/src/test/python/stacks/2.2/configs/hive-upgrade.json ee93b74 > > ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json > 42ee4ed > ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json > b8ed7d0 > ambari-server/src/test/python/stacks/2.2/configs/knox_upgrade.json 63b729e > ambari-server/src/test/python/stacks/2.2/configs/oozie-downgrade.json > 7e5346c > ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 1c75d65 > ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json > 7ad76de > > ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json > 7b770a7 > ambari-web/app/assets/data/stack_versions/upgrade.json 2b6188b > > contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/hooks/before-ANY/scripts/params.py > 02ef721 > > Diff: https://reviews.apache.org/r/53617/diff/ > > > Testing > ------- > > PENDING > > > Thanks, > > Jonathan Hurley > >
