> On Nov. 9, 2016, 1:13 p.m., Jonathan Hurley wrote: > > Ship It! > > Duc Le wrote: > I'm still figuring out how to review, so posting this comment here. Don't > we need to update the description on line 50? > > super(CheckDescription.HOSTS_MAINTENANCE_MODE);
Thanks for the review! That's a good point - I'll make the text a bit more descriptive for HOST_ORDERED. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53618/#review155465 ----------------------------------------------------------- On Nov. 9, 2016, 1:03 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53618/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 1:03 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-18723 > https://issues.apache.org/jira/browse/AMBARI-18723 > > > Repository: ambari > > > Description > ------- > > The check for hosts in MM should fail for HOST_ORDERED, instead of WARN > > Future jira should allow prereq checks based on upgrade type, but that is not > required yet. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java > 5e7bdef > > ambari-server/src/test/java/org/apache/ambari/server/checks/HostMaintenanceModeCheckTest.java > 0e14376 > > Diff: https://reviews.apache.org/r/53618/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
