> On 十一月 10, 2016, 3:02 p.m., Jonathan Hurley wrote: > > What's the state of this review? Has it been abandoned? If so, can we close > > it?
jhurley,thanks for your attention. There seem not have more feedbacks about this review request. If you are sure this funciton is repeated in new "wizard" workflow for alerts,i will close it later - yao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52183/#review155589 ----------------------------------------------------------- On 十月 13, 2016, 7:43 a.m., yao lei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52183/ > ----------------------------------------------------------- > > (Updated 十月 13, 2016, 7:43 a.m.) > > > Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Zhe (Joe) Wang, > Oleg Tikhonov, and Yusaku Sako. > > > Bugs: AMBARI-18423 > https://issues.apache.org/jira/browse/AMBARI-18423 > > > Repository: ambari > > > Description > ------- > > Ambari now only support creating/editing alert notifications of type > EMAIL/SNMP in web client. > This patch aims to support another notification type ALERT_SCRIPT > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java > 907588d > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > 10a7918 > ambari-web/app/messages.js 2c819e5 > ambari-web/app/templates/main/alerts/create_alert_notification.hbs a248e57 > > ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js > a0a4ce4 > > Diff: https://reviews.apache.org/r/52183/diff/ > > > Testing > ------- > > ambari-web/mvn test > > > 30365 tests complete (43 seconds) > 151 tests pending > > > Thanks, > > yao lei > >
