----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53673/#review155831 -----------------------------------------------------------
Fix it, then Ship it! ambari-agent/src/main/python/ambari_agent/HostCleanup.py (line 352) <https://reviews.apache.org/r/53673/#comment225925> Nitpick here, but add spaces surrounding the "+" Same in other lines below ambari-agent/src/main/python/ambari_agent/HostCleanup.py (line 354) <https://reviews.apache.org/r/53673/#comment225926> use str(pid) instead, also in lines below ambari-agent/src/main/python/ambari_agent/HostCleanup.py (line 356) <https://reviews.apache.org/r/53673/#comment225927> safer to use "with" statement to close file immediately after ambari-agent/src/main/python/ambari_agent/HostCleanup.py (line 361) <https://reviews.apache.org/r/53673/#comment225928> Can remove redundant parentheses - Alejandro Fernandez On Nov. 11, 2016, 4:33 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53673/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 4:33 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-18852 > https://issues.apache.org/jira/browse/AMBARI-18852 > > > Repository: ambari > > > Description > ------- > > a new feature to support stopping processes owned by users or java processes. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/HostCleanup.py cca79a8 > ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 165c5f0 > > Diff: https://reviews.apache.org/r/53673/diff/ > > > Testing > ------- > > unit test > patched a 2.5 cluster with the changes and run host cleanup with two .ini > files I created. > > > Thanks, > > Di Li > >
