----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53742/#review155853 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java (lines 191 - 192) <https://reviews.apache.org/r/53742/#comment225943> Yikes - I can just see this breaking if someone renamed/moves the file ... Can we make this a constant? Can we add a unit test to ensure that this file exists? ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml (lines 84 - 86) <https://reviews.apache.org/r/53742/#comment225944> So, does this make every generated task skippable? - Jonathan Hurley On Nov. 14, 2016, 4:41 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53742/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 4:41 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Duc Le. > > > Bugs: AMBARI-18879 > https://issues.apache.org/jira/browse/AMBARI-18879 > > > Repository: ambari > > > Description > ------- > > When executing a HOST_ORDERED upgrade, the host should have "hdp-select set > all" run ONLY for that host. This is similar to what we do during an RU > across all hosts after it's completed. When the stack supports reimaging, > this step can be removed as the entire host would have ONLY the new version > anyway. > > Made the host-group in the upgrade pack as skippable to allow a quick exit. > There was also some unused code in the AbstractUpgradeCatalog that shouldn't > be there. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > 623fb76 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 86f5c8d > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml > 37b75b8 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 6b4b85a > > Diff: https://reviews.apache.org/r/53742/diff/ > > > Testing > ------- > > Manual verification. Automated pending. > > > Thanks, > > Nate Cole > >
