----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53778/#review155899 -----------------------------------------------------------
Ship it! Ship It! - Balázs Bence Sári On Nov. 15, 2016, 10:06 a.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53778/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 10:06 a.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Balázs Bence > Sári, Laszlo Puskas, and Sandor Magyari. > > > Bugs: AMBARI-18891 > https://issues.apache.org/jira/browse/AMBARI-18891 > > > Repository: ambari > > > Description > ------- > > Added core-site config type as a dependency for oozie. This ensures that > whenever core-site is changed oozie will be flaged as having stale configs as > well indicating that a restart is needed as some of the configs it uses has > changed. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/metainfo.xml > 66d272a > > Diff: https://reviews.apache.org/r/53778/diff/ > > > Testing > ------- > > Manual testing. > > Unit tests: > there is only one failure which is not related to this change. > > Failed tests: > FAIL: test_update_directory_archive > (TestResourceFilesKeeper.TestResourceFilesKeeper) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File > "/Users/stoader/Projects/Hortonworks/apache/ambari/ambari-common/src/test/python/mock/mock.py", > line 1199, in patched > return func(*args, **keywargs) > File > "/Users/stoader/Projects/Hortonworks/apache/ambari/ambari-server/src/test/python/TestResourceFilesKeeper.py", > line 191, in test_update_directory_archive > self.assertTrue(write_hash_sum_mock.called) > AssertionError: False is not true > > > Thanks, > > Sebastian Toader > >
