-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53725/#review155907
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml (lines 
139 - 144)
<https://reviews.apache.org/r/53725/#comment225991>

    Are you sure this works? I don't think the XSD allows you to put an 
execute-stage in this location. 
    
    I was actually referring to something like this:
    
    ```
        <group xsi:type="cluster" name="UPDATE_KERBEROS_DESCRIPTORS" 
title="Update Kerberos Descriptors">
          <condition xsi:type="security" type="kerberos"/>
          <execute-stage title="Update the user-specified Kerberos descriptor">
            <task xsi:type="server_action" 
class="org.apache.ambari.server.serveraction.upgrades.UpgradeUserKerberosDescriptor"/>
          </execute-stage>
        </group>
    ```
    
    You can scope the new group type to service="RANGER" component="RANGER_KMS"


- Jonathan Hurley


On Nov. 15, 2016, 1:43 a.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53725/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2016, 1:43 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18834
>     https://issues.apache.org/jira/browse/AMBARI-18834
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add below properties during stack upgrade to 2.5 in kerberos environment 
> under kms-site.xml
> 
> - hadoop.kms.proxyuser.[ranger].groups=*
> - hadoop.kms.proxyuser.[ranger].hosts=*
> - hadoop.kms.proxyuser.[ranger].users=*
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfig.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  04e4f3e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  3233f7e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 95c5f06 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> a01996a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  05e2be1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  1a26e59 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> f0c6131 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> f520faf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKmsProxyConfigTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53725/diff/
> 
> 
> Testing
> -------
> 
> Tested EU from 2.4 to 2.5 stack in kerberos environment on centos 6.
> 
> 
> ------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support 
> was removed in 8.0
> Running 
> org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.679 sec - 
> in org.apache.ambari.server.serveraction.upgrades.RangerKmsProxyConfigTest
> 
> Results :
> 
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Reply via email to