> On Nov. 15, 2016, 7:17 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java, > > line 127 > > <https://reviews.apache.org/r/53684/diff/1/?file=1561866#file1561866line127> > > > > Nit - space after comma
Hi Sumit, The latest Diff 5 version, will not have this change since from Diff 2 we changed the approach of the fix. Diff 5 will continue to be - command = new ConfigurationDependenciesRecommendationCommand(recommendationsDir, recommendationsArtifactsLifetime, stackAdvisorScript, - Madhuvanthi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53684/#review155762 ----------------------------------------------------------- On Nov. 15, 2016, 6:28 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53684/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 6:28 p.m.) > > > Review request for Ambari, Sumit Mohanty and Swapan Shridhar. > > > Bugs: AMBARI-18866 > https://issues.apache.org/jira/browse/AMBARI-18866 > > > Repository: ambari > > > Description > ------- > > Applied logic for rolling over during creation of recommendations artifacts > greater than a certain set limit. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java > e175c69 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 6cc4120 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelperTest.java > 5190dea > > Diff: https://reviews.apache.org/r/53684/diff/ > > > Testing > ------- > > 1. Set the recommendations.artifacts.rollovermax = 5 > Expected : Calls to stack advisor > 5 roll over starting from 0 again. Hence > at any point of time there will be upto 5 folders only in > /var/run/ambari-server/stack-recommendations > 2. Do not set this value > Expected : Defaults to 100 > 3. Set the recommendations.artifacts.rollovermax = 0 > Expected : Defaults to 100 > > On ambari-server restart, the ids are reset as before. > > > Thanks, > > Madhuvanthi Radhakrishnan > >
