> On Nov. 15, 2016, 9:22 p.m., Jonathan Hurley wrote: > > You've made sure that we don't reference any of these in Python without > > sensible defaults?
looks like we don't - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53793/#review155957 ----------------------------------------------------------- On Nov. 15, 2016, 7:59 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53793/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 7:59 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-18899 > https://issues.apache.org/jira/browse/AMBARI-18899 > > > Repository: ambari > > > Description > ------- > > I think not marking HDFS as restart required when Ambari upgrades is a good > goal. > > In general its a difficult to get it right for all services. > * hadoop.security.key.provider.path > * dfs.encryption.key.provider.uri > > These two are removed by stack advisor when RANGER KMS does not exist. We > should find out why it got added on Ambari upgrade. This seems like a bug to > me. > * namenode_backup_dir > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > afaaee8 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/core-site.xml > 846b09e > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-site.xml > aad524d > > ambari-server/src/main/resources/stacks/PHD/3.0/services/HDFS/configuration/core-site.xml > 4f18611 > > ambari-server/src/main/resources/stacks/PHD/3.0/services/HDFS/configuration/hdfs-site.xml > 0fed58d > > Diff: https://reviews.apache.org/r/53793/diff/ > > > Testing > ------- > > Checked on cluster with Ranger installed. Upgraded Ambari 2.4.2->2.5.0 > without these properties, services were able to stop/start without issues. > > > Thanks, > > Dmitro Lisnichenko > >
