-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53674/
-----------------------------------------------------------
(Updated Nov. 15, 2016, 11:33 p.m.)
Review request for Ambari, Dmytro Sen, Jaimin Jetly, Sumit Mohanty, and Sid
Wagle.
Bugs: AMBARI-18857
https://issues.apache.org/jira/browse/AMBARI-18857
Repository: ambari
Description
-------
This issue is result of storm site being scattered between Storm service and
AMS service.
It is highly recommended to avoid such scattering of config sites across
services. Doing so requires special handling on FE and generates lots of new
flows that needs to be tested. storm site should only belong and be packaged
inside Storm service. If there are some configs of storm-site that needs to be
added if AMS is present then stack advisor can be leveraged to achieve that
objective
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
7059b90
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
d2f5862
ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
077590a
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
f9a3a9a
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 7124307
Diff: https://reviews.apache.org/r/53674/diff/
Testing
-------
Manually tested.
Python unit tests pass.
Java Unit tests pending.
Thanks,
Aravindan Vijayan
