-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52455/
-----------------------------------------------------------
(Updated Nov. 16, 2016, 5:29 p.m.)
Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li.
Bugs: AMBARI-18476
https://issues.apache.org/jira/browse/AMBARI-18476
Repository: ambari
Description
-------
AMBARI-12263 adds support for PAM as authentication mechanism for accessing
Ambari UI/REST. The changes in this review request cover the corresponding
changes in the amabri-admin code.
Since a new column groupt_type has been added for groups, the UI will display
labels for group type and enable/disable group delete/add member functionality
based on the group_type instead of the ldap_group flag.
Patch includes similar changes for users. The user_type will be used to
determine if the user can be deleted or if the user's password can be changed.
Diffs (updated)
-----
ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
2e7830b
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js
1f86393
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js
f7ed7ee
ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js
cd9b922
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js
660306c
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js
PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js
da63c6d
ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html
78a6884
ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html
b359ede
ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html
e576b28
Diff: https://reviews.apache.org/r/52455/diff/
Testing
-------
Manual testing.
Tests in ambari admin project ran clean.
PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)
File Attachments
----------------
New patch
https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch
Final patch
https://reviews.apache.org/media/uploaded/files/2016/10/04/3d025c3b-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch
Patch based on latest code
https://reviews.apache.org/media/uploaded/files/2016/11/04/7fa50e96-c66b-4c5e-9321-13b623ab0710__AMBARI-18476.patch
Patch for 2.5
https://reviews.apache.org/media/uploaded/files/2016/11/16/0d18da03-21c2-4360-90fa-b144d728ee2d__AMBARI-18476_2.5patch
Final patch for ambari trunk
https://reviews.apache.org/media/uploaded/files/2016/11/16/72fbbb65-b7f4-4e7b-bbf8-63cf872cc725__AMBARI-18476_0411.patch
Thanks,
Sangeeta Ravindran
