----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53819/#review156114 -----------------------------------------------------------
Fix it, then Ship it! ambari-metrics/ambari-metrics-common/pom.xml (line 159) <https://reviews.apache.org/r/53819/#comment226252> Missing shade for this? Cannot add specific versions to hadoop classpath. - Sid Wagle On Nov. 16, 2016, 8:38 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53819/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 8:38 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-18911 > https://issues.apache.org/jira/browse/AMBARI-18911 > > > Repository: ambari > > > Description > ------- > > PROBLEM > Storm Nimbus start fails intermittently due to metrics initialization error. > > BUG > StormTimelineMetricsReporter could not init correctly due to missing protocol > information. Another issue that was preventing Storm metrics to be seen was > because of the difference in the way the ams_collector_hosts python list was > converted to String representation. > > It worked when the representation was > collector.hosts=['test1.123.abc.def.local', 'test1.456.abc.def.local'] > > But failed for > collector.hosts=[u'test1.123.abc.def.local', u'test1.456.abc.def.local'] > > FIX > Added the protocol assignment in StormTimelineMetricsReporter. > Cleaned up logic to parse host names passed in through *.metrics2.properties. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-common/pom.xml c5d83d0 > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java > efa5cba > > ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/AbstractTimelineMetricSinkTest.java > PRE-CREATION > > ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java > 5c61e03 > > Diff: https://reviews.apache.org/r/53819/diff/ > > > Testing > ------- > > Manually tested. > > mvn clean test on ambari-metrics > > python unit tests passed. > > > Thanks, > > Aravindan Vijayan > >
