-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53855/
-----------------------------------------------------------

(Updated Nov. 18, 2016, 10:42 a.m.)


Review request for Ambari, Attila Doroszlai, Laszlo Puskas, and Sebastian 
Toader.


Bugs: AMBARI-18923
    https://issues.apache.org/jira/browse/AMBARI-18923


Repository: ambari


Description
-------

The livy user keytabs settings should be specified at LIVY_SERVER component 
level instead of service level.
This causes that all hosts that contain a SPARK component will get the keytab 
file for livy. Only the host that has LIVY_SERVER should get this keytab.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
934f3c6 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
0689e7f 

Diff: https://reviews.apache.org/r/53855/diff/


Testing (updated)
-------

only json confiugration changed, no new unittest was added

Manual testing. 
1. performed an express upgrade from HDP 2.4 -> 2.5
2. regenerted keytabs
3. checked there was no error

Running existing unittests (2 unrelated failure in the java tests):

 Python: Total run:1163 Total errors:0 Total failures:0

 Java: Tests run: 4772, Failures: 2, Errors: 0, Skipped: 37
 Failed tests: 
   ServiceComponentHostTest.testStaleConfigs:858 null
   
AsyncCallableServiceTest.testCallableServiceShouldCancelTaskWhenTimeoutExceeded:95
 
   Unexpected method call ScheduledExecutorService.schedule(EasyMock for 
interface java.util.concurrent.Callable, 500, MILLISECONDS):

 - ServiceComponentHostTest.testStaleConfigs:858 failed before applying the 
patch as well
 - Rerunning 
AsyncCallableServiceTest.testCallableServiceShouldCancelTaskWhenTimeoutExceeded 
passed at the second time


File Attachments
----------------

2.4
  
https://reviews.apache.org/media/uploaded/files/2016/11/17/7a5bad98-d981-46bb-96e8-10cbf782af7a__AMBARI-18923_branch-2.4.patch
2.5
  
https://reviews.apache.org/media/uploaded/files/2016/11/17/8a063970-bc7e-428a-a499-ec9addc05344__AMBARI-18923_branch-2.5.patch
trunk
  
https://reviews.apache.org/media/uploaded/files/2016/11/18/a3dd7d79-56f1-4fcd-8fae-3079d1e7b80b__AMBARI-18923_trunk.patch


Thanks,

Attila Magyar

Reply via email to