-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53881/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and
Sid Wagle.
Bugs: AMBARI-18933
https://issues.apache.org/jira/browse/AMBARI-18933
Repository: ambari
Description
-------
{{ConfigGroupImpl}} uses internal locks around state which can lead to
deadlocks when this in called in the context of other business objects. In most
cases, this state-full data does not need locks placed around it.
{{ConfigGroupImpl}} should be changed to:
- No longer store entity information
- No longer require locks around primitive state
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
b957f0a
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
8b157c7
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroup.java
1b29c9b
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupFactory.java
9abadf3
ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java
9a2fc88
Diff: https://reviews.apache.org/r/53881/diff/
Testing
-------
Lots of unit tests broken - working on correcting those now.
Thanks,
Jonathan Hurley
