----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53947/#review156457 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Nov. 21, 2016, 4:31 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53947/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2016, 4:31 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-18948 > https://issues.apache.org/jira/browse/AMBARI-18948 > > > Repository: ambari > > > Description > ------- > > Currently, the only "enable" config param we set on hive to enable metrics > logging from hive is "hive.metastore.metrics.enabled". This parameter winds up > enabling the metrics system for both the metastore as well as HS2 (since HS2 > typically runs with embedded metastore, and the metrics we log for HS2 include > these api calls up front and center in Grafana). > > However, this is an issue in that we're not enabling/tracking metrics for HS2 > instances that run with a remote metastore, since that is enabled by a > different flag, called "hive.server2.metrics.enabled". This flag also needs to > be set when metrics is enabled. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hivemetastore-site.xml > b73b1ae > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hiveserver2-interactive-site.xml > 89bf43c > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hiveserver2-site.xml > e120ac2 > > Diff: https://reviews.apache.org/r/53947/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
