-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53958/
-----------------------------------------------------------
Review request for Ambari, Di Li and Jayush Luniya.
Bugs: AMBARI-18934
https://issues.apache.org/jira/browse/AMBARI-18934
Repository: ambari
Description
-------
With the addition of AMBARI-18846 which allows custom services to supply their
own dashboards and service metrics.
With this change, if a service has a dashboards directory within its service
definition, the grafana-dashboards subdirectory would be linked to
resources/dashboards/grafana-dashboards/MYSERVICE.
The dashboards/service-metrics/MYSERVICE.txt would be linked to
resources/dashboards/service-metrics/MYSERVICE.txt.
Diffs
-----
ambari-server/pom.xml 36c57de
ambari-server/src/main/python/ambari_server/serverConfiguration.py 3086003
ambari-server/src/main/python/ambari_server/setupMpacks.py 773d946
ambari-server/src/test/python/TestMpacks.py 7fb21ae
ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/grafana-dashboards/grafana-hdfs-users.json
PRE-CREATION
ambari-server/src/test/python/mpacks/mystack-ambari-mpack-1.0.0.1/stacks/MYSTACK/3.0/services/SERVICEC/dashboards/service-metrics/STORM.txt
PRE-CREATION
ambari-server/src/test/python/uninstall/common-services/SERVICEA PRE-CREATION
ambari-server/src/test/python/uninstall/common-services/SERVICEB PRE-CREATION
ambari-server/src/test/python/uninstall/dashboards/SERVICEA PRE-CREATION
ambari-server/src/test/python/uninstall/dashboards/SERVICEB PRE-CREATION
ambari-server/src/test/python/uninstall/dashboards/files/README.txt
PRE-CREATION
ambari-server/src/test/python/uninstall/dashboards/files/STORM.txt
PRE-CREATION
ambari-server/src/test/python/uninstall/dashboards/files/metainfo.xml
PRE-CREATION
ambari-server/src/test/python/uninstall/extensions/SERVICEA PRE-CREATION
ambari-server/src/test/python/uninstall/extensions/SERVICEB PRE-CREATION
ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEA PRE-CREATION
ambari-server/src/test/python/uninstall/stacks/2.0/SERVICEB PRE-CREATION
ambari-server/src/test/python/uninstall/stacks/2.0/files/README.txt
PRE-CREATION
ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo1.xml
PRE-CREATION
ambari-server/src/test/python/uninstall/stacks/2.0/files/metainfo2.xml
PRE-CREATION
Diff: https://reviews.apache.org/r/53958/diff/
Testing
-------
mvn clean test
Thanks,
Tim Thorpe
