-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53953/
-----------------------------------------------------------
(Updated Nov. 22, 2016, 1:20 p.m.)
Review request for Ambari, Attila Magyar, Laszlo Puskas, Sandor Magyari, and
Sebastian Toader.
Changes
-------
Inheritance is handled now.
Bugs: AMBARI-18949
https://issues.apache.org/jira/browse/AMBARI-18949
Repository: ambari
Description
-------
Quick link data json should have an optional properties field for each link.
This field is a list of Strings and can contain informative tags about the
quicklink such a sso or authenticated.
New json parser should be compatible with legacy quick links not having this
field.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
091926f
ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
38176aa
ambari-server/src/test/resources/child_quicklinks_with_properties.json
PRE-CREATION
ambari-server/src/test/resources/parent_quicklinks_with_properties.json
PRE-CREATION
Diff: https://reviews.apache.org/r/53953/diff/
Testing
-------
- Wrote new unit test
- Did manual testing
- Run all tests in ambari-server. Failures were irrelevant.
Failed tests:
UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1118
Unexpected method call
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface
org.apache.ambari.server.state.Cluster, EasyMock for interface
org.apache.ambari.server.state.Service):
AmbariManagementController.getClusters(): expected: at least 0, actual: 1
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for
interface org.apache.ambari.server.state.Cluster, EasyMock for interface
org.apache.ambari.server.state.Service): expected: 1, actual: 0
DataStoreImplTest.testFind:526 expected:<class
DS_DataStoreImplTest$TestEntity_1> but was:<class
DS_DataStoreImplTest$TestSubEntity_1>
DataStoreImplTest.testRemove:475 expected:<class
DS_DataStoreImplTest$TestEntity_1> but was:<class
DS_DataStoreImplTest$TestSubEntity_1>
DataStoreImplTest.testStore_update:357 expected:<class
DS_DataStoreImplTest$TestEntity_1> but was:<class
DS_DataStoreImplTest$TestSubEntity_1>
DataStoreImplTest.testStore_update_longStringValue:426
Expectation failure on verify:
DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
KerberosCheckerTest.testCheckFailed » Unexpected exception,
expected<org.apac...
KerberosCheckerTest.testCheckPassed:62 » ClassCast class
sun.security.provider...
AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:98 »
Linkage
ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 » Ambari File
/Us...
Thanks,
Balázs Bence Sári
